refactor: allow custom predicates as option #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KevFan <[email protected]>
Signed-off-by: KevFan <[email protected]>
guicassolato
previously approved these changes
Sep 27, 2024
Signed-off-by: KevFan <[email protected]>
guicassolato
approved these changes
Sep 30, 2024
Boomatang
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to: Kuadrant/kuadrant-operator#885
Allow passing custom predicates as an option to the watch func for the state reconciler.
This removes setting the
&ctrlruntimepredicate.TypedGenerationChangedPredicate[T]{}predicate by default as this may not be the functionality a user expects, as events revolving around status updates are skipped.For example, a user might want to receive only status change events for some resources (such as in Kuadrant Operator that watches status change of
Certificate,Issuer&ClusterIssuerto calculate the status forTLSPolicy)