Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response is not added to response.success.headers #142

Closed
jsmolar opened this issue Nov 11, 2024 · 3 comments · Fixed by #144
Closed

Response is not added to response.success.headers #142

jsmolar opened this issue Nov 11, 2024 · 3 comments · Fixed by #144
Assignees
Labels
bug Something isn't working

Comments

@jsmolar
Copy link

jsmolar commented Nov 11, 2024

No data is added to the request sent upstream when response.success.headers is used. The header is correctly added when I use the same spec for AuthConfig and standalone authorino.

AuthPolicy:

spec:
  rules:
    authentication:
      default:
        credentials:
          authorizationHeader:
            prefix: Bearer
        jwt:
          issuerUrl: 'http://10.0.96.144:8080/realms/realm-jsmolar--ykuo'
          ttl: 0
    response:
      success:
        headers:
          simple:
            json:
              properties:
                data:
                  selector: auth
            metrics: false
            priority: 0

When using the wasm-shim instead of the ExtAuthFilter, the upstream never sees the headers added to the request.

@adam-cattermole
Copy link
Member

I'll take a look at this, it might be the case that the way authorino is returning the headers is unexpected to the wasm-shim

@adam-cattermole adam-cattermole self-assigned this Nov 11, 2024
@alexsnaps alexsnaps transferred this issue from Kuadrant/kuadrant-operator Nov 12, 2024
@alexsnaps alexsnaps moved this to In Progress in Kuadrant Nov 12, 2024
@alexsnaps alexsnaps added the bug Something isn't working label Nov 12, 2024
@alexsnaps
Copy link
Member

alexsnaps commented Nov 12, 2024

@adam-cattermole
Copy link
Member

First two are fixed in #143

@adam-cattermole adam-cattermole linked a pull request Nov 13, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in Kuadrant Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants