Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify the gRPC calls from the wasm-shim do propagate the traceid #47

Closed
alexsnaps opened this issue Jan 19, 2024 · 2 comments
Closed
Assignees
Milestone

Comments

@alexsnaps
Copy link
Member

No description provided.

@alexsnaps alexsnaps transferred this issue from Kuadrant/architecture Jan 19, 2024
@alexsnaps alexsnaps moved this to Todo in Kuadrant Jan 19, 2024
@alexsnaps alexsnaps added this to the v0.4.0 milestone Jan 22, 2024
@alexsnaps alexsnaps moved this from Todo to In Progress in Kuadrant Feb 19, 2024
@adam-cattermole
Copy link
Member

adam-cattermole commented Feb 19, 2024

Currently the trace headers are not propagated if envoy starts the trace, see the discussion here https://envoyproxy.slack.com/archives/CM2CQ4XJ5/p1707487817883799.

Related issue is here: envoyproxy/envoy#22028

@adam-cattermole
Copy link
Member

A minor follow up - I've investigated the option of generating the traceparent header ourselves and adding this to the request in wasm-shim. If for example we add the traceparent header here https://github.com/Kuadrant/wasm-shim/blob/main/src/filter/http_context.rs#L209 through self.add_http_request_header(), it still ends up being propagated back through to authorino.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants