Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev environment: fix authorino deployment #114

Merged
merged 3 commits into from
Oct 23, 2024
Merged

dev environment: fix authorino deployment #114

merged 3 commits into from
Oct 23, 2024

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Oct 22, 2024

What

Authorino deployment changed and webhook is no longer needed Kuadrant/authorino-operator#219

  • Removed TLS overlay, as not relevant for the wasm-shim.
  • Leverage limtiador operator for deployment.

@eguzki eguzki changed the title fix authorino deployment dev environment: fix authorino deployment Oct 22, 2024
Signed-off-by: Eguzki Astiz Lezaun <[email protected]>
Signed-off-by: Eguzki Astiz Lezaun <[email protected]>
Copy link
Member

@didierofrivia didierofrivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🏭

@eguzki
Copy link
Contributor Author

eguzki commented Oct 23, 2024

@adam-cattermole merging this.

Please let me know if TLS overlay is still useful for the dev environment. I am more than happy to bring it back. I just do not see a value of the TLS which is totally delegated to Envoy and we were duplicating wasm configurations in both overlies.

@eguzki eguzki merged commit f5caadd into main Oct 23, 2024
9 checks passed
@eguzki eguzki deleted the fix-deployment branch October 23, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants