Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clippy Allowing warnings #80

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Clippy Allowing warnings #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/rust.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,4 +71,4 @@ jobs:
- uses: actions-rs/cargo@v1
with:
command: clippy
args: --all-targets --all-features -- -D warnings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is opening the door for all the warnings. Today have none due to this.

Are we sure we want this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alternative is to pin rustc to 1.80, the one that is marking the allowing of box_pointers is rustc 1.81.0 (eeb90cda1 2024-09-04)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about updating src/envoy path content? I am aware it is auto-generated from protobuf descriptors. So maybe change the source of truth or add some customization https://github.com/Kuadrant/wasm-shim/blob/main/build.rs#L55-L106

It is all about deleting

#![allow(box_pointers)]

That is a lint being removed in rust 1.80

args: --all-targets --all-features # TODO: Re-add `-- -D warnings` when https://github.com/stepancheg/rust-protobuf/pull/733 is released to new version of crate
Loading