Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Transport for EMF HAFAS #15

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

TheEnbyperor
Copy link

No description provided.

Copy link
Owner

@Kunsi Kunsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a more general note: please sort all imports in python files using isort for a consistent import style.

break
if SYMBOL_IS_GROUP[CONFIG["api_provider"]]:
if dep.symbol == follow.symbol and (
(dep.platform != "" and dep.platform == follow.platform)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation seems wrong here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what clicking "reformat code" in PyCharm outputs

@Kunsi
Copy link
Owner

Kunsi commented Mar 18, 2024

Due to the implementation of code style checks and the corresponding fixes to the code style, please rebase to main and format the code according to the checks.

.idea/.gitignore Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add .idea to your global gitignore? We should not have editor configs in this repository.

COPYRIGHT Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed we're missing licensing information for the newly added fonts and the NRE logo.

@Kunsi Kunsi force-pushed the main branch 3 times, most recently from 6004a8f to e782f81 Compare June 10, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants