Skip to content

Commit a1f6274

Browse files
committed
Merge branch 'hotfix/240605/rename-from-export_batch-to-process_batch' into 'master'
[DEX-240605] hotfix: rename from export_batch to process_batch See merge request nstmrt/rubygems/sbmt-kafka_consumer!52
2 parents 69bf6d5 + 26c3983 commit a1f6274

File tree

5 files changed

+19
-13
lines changed

5 files changed

+19
-13
lines changed

CHANGELOG.md

+6
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
1313

1414
### Fixed
1515

16+
## [2.3.1] - 2024-06-05
17+
18+
### Fixed
19+
20+
- Rename from `export_batch` to `process_batch`
21+
1622
## [2.3.0] - 2024-05-30
1723

1824
### Added

README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -233,14 +233,14 @@ require_relative "config/environment"
233233
some-extra-configuration
234234
```
235235

236-
### `Export batch`
236+
### `Process batch`
237237

238-
To process messages in batches, you need to add the `export_batch` method in the consumer
238+
To process messages in batches, you need to add the `process_batch` method in the consumer
239239

240240
```ruby
241241
# app/consumers/some_consumer.rb
242242
class SomeConsumer < Sbmt::KafkaConsumer::BaseConsumer
243-
def export_batch(messages)
243+
def process_batch(messages)
244244
# some code
245245
end
246246
end

lib/sbmt/kafka_consumer/base_consumer.rb

+6-6
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ def self.name
1717

1818
def consume
1919
::Rails.application.executor.wrap do
20-
if export_batch?
20+
if process_batch?
2121
with_batch_instrumentation(messages) do
22-
export_batch(messages)
22+
process_batch(messages)
2323
mark_as_consumed!(messages.last)
2424
end
2525
else
@@ -30,11 +30,11 @@ def consume
3030
end
3131
end
3232

33-
def export_batch?
34-
if @export_batch_memoized.nil?
35-
@export_batch_memoized = respond_to?(:export_batch)
33+
def process_batch?
34+
if @process_batch_memoized.nil?
35+
@process_batch_memoized = respond_to?(:process_batch)
3636
end
37-
@export_batch_memoized
37+
@process_batch_memoized
3838
end
3939

4040
private

lib/sbmt/kafka_consumer/version.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22

33
module Sbmt
44
module KafkaConsumer
5-
VERSION = "2.3.0"
5+
VERSION = "2.3.1"
66
end
77
end

spec/sbmt/kafka_consumer/base_consumer_spec.rb

+3-3
Original file line numberDiff line numberDiff line change
@@ -97,8 +97,8 @@ def process_message(_message)
9797
let(:consumer_class) do
9898
Class.new(described_class.consumer_klass) do
9999
attr_reader :consumed
100-
def export_batch(messages)
101-
Rails.logger.info "Export batch #{messages.count} messages"
100+
def process_batch(messages)
101+
Rails.logger.info "Process batch #{messages.count} messages"
102102
@consumed = true
103103
end
104104

@@ -119,7 +119,7 @@ def consumed?
119119
it "consumes" do
120120
consume_with_sbmt_karafka
121121
expect(consumer).to be_consumed
122-
expect(Rails.logger).to have_received(:info).with(/Export batch/)
122+
expect(Rails.logger).to have_received(:info).with(/Process batch/)
123123
end
124124
end
125125
end

0 commit comments

Comments
 (0)