Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newline not working #3

Open
juulie opened this issue Sep 1, 2011 · 11 comments
Open

Newline not working #3

juulie opened this issue Sep 1, 2011 · 11 comments

Comments

@juulie
Copy link

juulie commented Sep 1, 2011

When searching for a string that covers multiple lines, the frame comes out wrong. This is due to the fact the search doesn't seem to account multiple lines (while i think this is implemented). I did notice that T* ' and "" operators are set up, but they aren't being called.

@KurtCode
Copy link
Owner

KurtCode commented Sep 4, 2011

It is a known limitation that selections ignore line breaks, so the selection will just keep going off the end of the line, until an area equal to that of the keyword string is marked. The shape of a multi-line selection is simply not a rectangle. That's the root issue.

We are considering a neat solution where a selection may be broken up into multiple subselection, each of which is a rectangle.

As for operators, not all are called by every document, as some of them (like T-star and double qoute) are redundant, or short hand/syntactic sugar.

@juulie
Copy link
Author

juulie commented Sep 4, 2011

Ok, i do need it for my current project so i'm working on a solution myself (which i'll obviously share when i made it).

About the opertors, i did notice that Tm gets called a lot (at least at each new line), cant we do something with that?

@juulie juulie closed this as completed Sep 4, 2011
@juulie juulie reopened this Sep 4, 2011
@KurtCode
Copy link
Owner

KurtCode commented Sep 4, 2011

Thanks, I'd really appreciate any contribution.

Yeah, for each Tm (commonly representing line breaks) we could "cut" the selection. I mean, finalize it as if it was really the end of the keyword, but then start a new selection and keeping pointers between consequtive selection rectangles.

BTW, ain't that "close" button the worst? ;) Keep hitting it by mistake too...

@juulie
Copy link
Author

juulie commented Sep 4, 2011

Ah I see, guess I misread the adobe documentation. But that would work.

And yes, it is a bit weird, they should color it red or something :P

@juulie
Copy link
Author

juulie commented Sep 5, 2011

Thing is, while Tm marks a new line, it doesnt mark the end or position of the previous, so we'll have to figure something else for that.

@KurtCode
Copy link
Owner

KurtCode commented Sep 5, 2011

That would be the current state, just before the Tm arrives. The framework constantly keeps the current rendering state up to date.

@juulie
Copy link
Author

juulie commented Sep 5, 2011

But for some reason, the current rendering state's line and testmatrix are identity matrices.

@juulie
Copy link
Author

juulie commented Sep 5, 2011

(at that point)

@juulie
Copy link
Author

juulie commented Sep 5, 2011

nvm, its due to BT, i can just store the coordinates just before that point. Will come back when i have the final solution ;)

@jonnermut
Copy link

any progress?

@KurtCode
Copy link
Owner

No.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants