fix podopslifecycle set readiness gate order (#298)

KusionStack · Oct 29, 2024 · d95fb01 · d95fb01
1 parent e4e981f
commit d95fb01
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/pkg/controllers/podopslifecycle/podopslifecycle_controller.go b/pkg/controllers/podopslifecycle/podopslifecycle_controller.go
@@ -185,8 +185,11 @@ func (r *ReconcilePodOpsLifecycle) Reconcile(ctx context.Context, request reconc
 		v1alpha1.PodPreparingLabelPrefix:  false, // Set readiness gate to false
 		v1alpha1.PodCompletingLabelPrefix: true,  // Set readiness gate to true
 	}
-	for phaseLabel, expectedReadinessGateStatus := range expected {
+	// preparing phase goes before completing phase
+	orderedKeys := []string{v1alpha1.PodPreparingLabelPrefix, v1alpha1.PodCompletingLabelPrefix}
+	for _, phaseLabel := range orderedKeys {
 		keeped := false
+		expectedReadinessGateStatus := expected[phaseLabel]
 		for _, labels := range idToLabelsMap {
 			if _, ok := labels[phaseLabel]; !ok {
 				continue