Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add workspace config apis for kusion server #1311

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

liu-hm19
Copy link
Contributor

@liu-hm19 liu-hm19 commented Nov 12, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds the workspace config-related apis for kusion server.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@liu-hm19 liu-hm19 added the kind/feature Categorizes issue or PR as related to a new feature label Nov 12, 2024
@liu-hm19 liu-hm19 self-assigned this Nov 12, 2024
@coveralls
Copy link

coveralls commented Nov 12, 2024

Pull Request Test Coverage Report for Build 11832783033

Details

  • 11 of 266 (4.14%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 48.864%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/domain/request/workspace_request.go 0 3 0.0%
pkg/server/manager/workspace/types.go 0 11 0.0%
pkg/server/manager/workspace/workspace_manager.go 0 12 0.0%
pkg/server/handler/workspace/configs.go 0 52 0.0%
pkg/server/manager/workspace/configs.go 0 177 0.0%
Totals Coverage Status
Change from base Build 11830314219: -0.6%
Covered Lines: 10558
Relevant Lines: 21607

💛 - Coveralls

@liu-hm19 liu-hm19 changed the title feat: add workspace apis for kusion server feat: add workspace config apis for kusion server Nov 13, 2024
ffforest
ffforest previously approved these changes Nov 13, 2024
Copy link
Contributor

@ffforest ffforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ffforest
Copy link
Contributor

lgtm

@ffforest ffforest merged commit a77a571 into KusionStack:main Nov 14, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants