Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification System Not implemented #2

Open
Kyle-Ye opened this issue Jun 3, 2023 · 6 comments
Open

Notification System Not implemented #2

Kyle-Ye opened this issue Jun 3, 2023 · 6 comments
Assignees
Labels
Feat New feature or request P0
Milestone

Comments

@Kyle-Ye
Copy link
Owner

Kyle-Ye commented Jun 3, 2023

No description provided.

@Kyle-Ye Kyle-Ye added the Feat New feature or request label Jun 3, 2023
@Kyle-Ye Kyle-Ye self-assigned this Jun 3, 2023
@Kyle-Ye Kyle-Ye added the P0 label Jun 3, 2023
@Kyle-Ye Kyle-Ye modified the milestones: TestFlight 0.3.0, 0.3.0, 0.4.0 Jun 4, 2023
@Kyle-Ye Kyle-Ye modified the milestones: 0.4.0, 1.0.0 Jun 18, 2023
@Kyle-Ye
Copy link
Owner Author

Kyle-Ye commented Nov 26, 2023

Consider support in in 0.9.0.

https://docs.discourse.org/#tag/Notifications

If you are interested in this project and like to contribute, maybe you could take a look at this. 🥰 @Lakr233

@Lakr233
Copy link

Lakr233 commented Nov 26, 2023

I'll take the job when I'm free, not too soon.

And for APN, the notification support for these kind of project requires either two way:

  • code to be executed on server side
    • server plugin (requires admin privilege)
    • web hook (if provided as user configurable)
  • background fetch (not reliable but work most of time) (example: Kimis)

Which one you prefer?

@Kyle-Ye
Copy link
Owner Author

Kyle-Ye commented Nov 26, 2023

Which one you prefer?

Both seem fine for me. I haven’t written much APN code before.

Does the first method require a external server to support it? I prefer a solution that does not rely on an external server.

web hook (if provided as user configurable)

When creating a user-api-key from a discourse server, we can add push_url as a parameter.

  • push_url: url to push notifications)

See more info here https://meta.discourse.org/t/user-api-keys-specification/48536

@Kyle-Ye Kyle-Ye assigned Lakr233 and unassigned Kyle-Ye Nov 26, 2023
@Kyle-Ye
Copy link
Owner Author

Kyle-Ye commented Nov 26, 2023

I'll take the job when I'm free, not too soon.

Thanks. I've assigned this issue to you.

Feel free to cancel the assignment if you have other plan.

@Lakr233
Copy link

Lakr233 commented Nov 26, 2023

Web Hook requires an application to extract information from the hook, and translate it to APN endpoint. So an external server is required. Talked with author of Mastoot, he host a server jsut for that.

@Kyle-Ye
Copy link
Owner Author

Kyle-Ye commented Nov 26, 2023

  • background fetch (not reliable but work most of time) (example: Kimis)

Then I think the second one is our best choice. 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feat New feature or request P0
Projects
None yet
Development

No branches or pull requests

2 participants