Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad hack #4

Open
sarthou opened this issue Jan 6, 2021 · 1 comment
Open

Bad hack #4

sarthou opened this issue Jan 6, 2021 · 1 comment
Assignees

Comments

@sarthou
Copy link
Member

sarthou commented Jan 6, 2021

if success1 and success2 and (not (obj1.id in self.pick_map)) and (not (obj2.id in self.pick_map)):

if success1 and success2 and (not (obj1.id in self.pick_map)) and (not (obj2.id in self.pick_map)):

It seems that you only block relations computation's for picked objects rather than attaching them to the gripper to get their position or discarding them (the first solution is the best in my opinion).

With your current solution, even if you know that an object has been picked, if you don't perceive it again before a drop in a box, the object will stay here forever. Worst, if the object is dropped, you erase it from your map and in the case where it has not been seen since, it will first stay at the previous position and the facts will be published again.

@Alexandre-Bonneau
Copy link

I cleaned-up the code, those functions are still there, but not in the same place, so I add the new links

and (not (obj1.id in self.pick_map))):

and (not (obj2.id in self.pick_map))):

(not (obj2.id in self.pick_map))):

and (not (obj1.id in self.pick_map))) :

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants