Add FIlterSet and InstrumentFilterSet models #72
+158
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm: add/increase runcadencestrategies resource constraints
Three filters for every standard observation.
phycodurus
approved these changes
Dec 2, 2024
| filter_dates.append([inst_filter, inst_filter.get_last_calibration_age(self.dynamic_cadence.observation_group)]) # TODO: explore an annotation instead | ||
|
|
||
There was a problem hiding this comment.
the linter will choke on this: you can pip install flake8 and run it on your repo before you make your commits like this:
flake8 calibration_tom* --exclude=*/migrations/* --max-line-length=120
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create FilterSet and InstrumentFilterSet models. Create update_observation_filterset function to select only specific filtersets.
The get_last_instrumentfilterset_age method defines the filterset_age as the maximum age of the individual filters. This may cause the "middle" filterset (BVR for Johnson-Cousins, gri for Sloan) to not get selected.