Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine zcat and mag stages #67

Open
griffin-h opened this issue Sep 16, 2020 · 1 comment
Open

Combine zcat and mag stages #67

griffin-h opened this issue Sep 16, 2020 · 1 comment

Comments

@griffin-h
Copy link
Collaborator

griffin-h commented Sep 16, 2020

It occurred to me after our discussion today that it would be simpler to avoid mixing aperture and PSF photometry if there were not two separate stages where the user has to specify which one to use. The mag stage is a very simple operation: applying previously calculated zero points and color terms to the supernova magnitude. I can't think of a reason this can't be done at the same time that the zero points and color terms are calculated. In fact it would be easier to do it that way.

This would be a relatively simple change for normal images. It might take some thinking to apply it to difference images as well.

This would also avoid the confusing behavior when the magnitude stage is run with only a subset of the data (e.g., Issues #23 and #66).

@griffin-h
Copy link
Collaborator Author

Standard star images are the only ones where zcat is run but not mag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant