Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules should not explicitly refer to scripts as inputs #166

Open
rdmorin opened this issue Jan 18, 2021 · 0 comments
Open

Rules should not explicitly refer to scripts as inputs #166

rdmorin opened this issue Jan 18, 2021 · 0 comments

Comments

@rdmorin
Copy link
Collaborator

rdmorin commented Jan 18, 2021

The setting of scripts used by specific rules as explicit inputs to that rule is problematic. When a second user is using a different copy of the lcr-modules repo the pipeline will then force re-running of the rules that depend on that input file. For example, if the following rule is run by user B (let's call her Laura... no, Dr. H) on a partially completed run of the pipeline (run by user A, or Dr. M), it will trigger a complete rerun of the pipeline by user A. I see no reason a script should ever be an input to a rule. These should be changed to params or, possibly better yet, just put into "src" and used by exporting that directory to the PATH at the start of the rule.

rule _manta_augment_vcf:
    input:
        variants_dir = str(rules._manta_run.output.variants_dir),
        aug_vcf = CFG["inputs"]["augment_manta_vcf"]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants