Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Repository to Automatic Dependency updates (access-update-scripts) #27

Open
jermnelson opened this issue Sep 7, 2021 · 3 comments
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request good first issue Good for newcomers

Comments

@jermnelson
Copy link
Contributor

jermnelson commented Sep 7, 2021

Add this repository to https://github.com/sul-dlss/access-update-scripts now that it supports Poetry using Python projects 🐍

This ticket was also about automatic deployments, which we don't have a consistent or widely used pattern for with Docker images, so I'll ticket that separately, since the automatic dependency updates and automatic deployment (or deployment as part of the manually triggered sdr-deploy script) is a somewhat orthogonal concern.

As noted below (still the case as of this update), sdr-deploy really only handles projects that use Capistrano for deployment, at this point, and is very tailored towards infra apps that use Capistrano to deploy to on prem VMs.

@aaron-collier
Copy link
Contributor

@jermnelson / @justinlittman, 2 questions:
1 - Since I don't think access-update-scripts has any python based repos, and we've had some trouble extending that repo, this may be blocked. Though if sul-dlss/access-update-scripts#174 goes in we could add this as "update: False" initially

and

2 - Do we want to work towards adding some helm/kubectl to sdr-deploy? Otherwise we probably can't do much here at this time.

Overall, i think this may be blocked, but I'm open to suggestion.

@mjgiarlo
Copy link
Member

IIRC sdr-deploy is 100% Ruby projects; it's essentially a wrapper around capistrano. Given fuzziness around the long-term portfolio home for Sinopia, I think we should continue to hold off on this.

@jmartin-sul
Copy link
Contributor

jmartin-sul commented Apr 5, 2023

while automatic deployment is still an open question here, access-update-scripts does now support python projects, e.g. https://github.com/sul-dlss/was-pywb/ is listed here

updated description to reflect this.

@jmartin-sul jmartin-sul added enhancement New feature or request good first issue Good for newcomers dependencies Pull requests that update a dependency file labels Apr 5, 2023
@jmartin-sul jmartin-sul changed the title Add Repository to Automatic Deployment Add Repository to Automatic Dependency updates (access-update-scripts) Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants