Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Symphony Tasks by extending SimpleHttpOperator #78

Open
jermnelson opened this issue Oct 20, 2021 · 0 comments
Open

Refactor Symphony Tasks by extending SimpleHttpOperator #78

jermnelson opened this issue Oct 20, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@jermnelson
Copy link
Contributor

The first implementation of the Symphony Tasks returned a SimpleHttpOperator after setting Symphony specific HTTP headers and body depending on the action. This was refactored in #77 to use a PythonOperator because upstream tasks XCOM variables were not available when passing in values to the functions parameters. We're using the requests package to handle HTTP requests within these functions which includes handling HTTP errors.

An alternative would be to extend the existing SimpleHttpOperator with a custom operator and specify the incoming parameters marc_json and token to the NewMARCtoSymphonytemplates.

@jermnelson jermnelson added the enhancement New feature or request label Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant