Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate result in Subject lookup #189

Open
JoannaDatSUL opened this issue Aug 19, 2019 · 3 comments
Open

duplicate result in Subject lookup #189

JoannaDatSUL opened this issue Aug 19, 2019 · 3 comments
Labels
authority tests needs connection tests or accuracy tests for an authority cache Indexing Moderate Priority moderate priority - probably needed but not critical at this time qa configs work needs to happen at the qa config level

Comments

@JoannaDatSUL
Copy link

Subject lookup (field 3) for LCSH "Public welfare" brought up a list with double entry for "Public welfare" (in stage, windows, chrome)
image

@michelleif michelleif changed the title Subject lookup duplicate result in Subject lookup Sep 9, 2019
@justinlittman
Copy link

I couldn't reproduce this for public welfare. However, I could for "public records". QA returns multiple results which have the label "public records" but different URIs:

[
  {
    "uri": "http://id.loc.gov/authorities/subjects/sh2002006377",
    "id": "http://id.loc.gov/authorities/subjects/sh2002006377",
    "label": "Public records",
    "context": [
      {
        "property": "Preferred label",
        "values": [
          "Public records"
        ],
        "selectable": true,
        "drillable": false
      },
      {
        "property": "Type",
        "values": [
          "http://www.loc.gov/mads/rdf/v1#Authority",
          "http://www.w3.org/2004/02/skos/core#Concept",
          "http://www.loc.gov/mads/rdf/v1#Topic"
        ],
        "selectable": false,
        "drillable": false
      },
      {
        "group": "Hierarchy",
        "property": "Broader",
        "values": [
          {
            "uri": "http://id.loc.gov/authorities/subjects/sh99001916",
            "id": [],
            "label": []
          }
        ],
        "selectable": true,
        "drillable": true
      }
    ]
  },
  {
    "uri": "http://id.loc.gov/authorities/subjects/sh85108750",
    "id": "http://id.loc.gov/authorities/subjects/sh85108750",
    "label": "Public records",
    "context": [
      {
        "property": "Preferred label",
        "values": [
          "Public records"
        ],
        "selectable": true,
        "drillable": false
      },
      {
        "property": "Alternative label",
        "values": [
          "Government records"
        ],
        "selectable": false,
        "drillable": false
      },
      {
        "property": "Type",
        "values": [
          "http://www.loc.gov/mads/rdf/v1#Authority",
          "http://www.w3.org/2004/02/skos/core#Concept",
          "http://www.loc.gov/mads/rdf/v1#Topic"
        ],
        "selectable": false,
        "drillable": false
      },
      {
        "group": "Hierarchy",
        "property": "Broader",
        "values": [
          {
            "uri": "http://id.loc.gov/authorities/subjects/sh85108611",
            "id": [],
            "label": []
          },
          {
            "uri": "http://id.loc.gov/authorities/subjects/sh85111938",
            "id": [],
            "label": []
          }
        ],
        "selectable": true,
        "drillable": true
      },
      {
        "group": "Hierarchy",
        "property": "Narrower",
        "values": [
          {
            "uri": "http://id.loc.gov/authorities/subjects/sh90004695",
            "id": [],
            "label": []
          },
          {
            "uri": "http://id.loc.gov/authorities/subjects/sh85033486",
            "id": [],
            "label": []
          },
          {
            "uri": "http://id.loc.gov/authorities/subjects/sh85033556",
            "id": [],
            "label": []
          },
          {
            "uri": "http://id.loc.gov/authorities/subjects/sh98001207",
            "id": [],
            "label": []
          },
          {
            "uri": "http://id.loc.gov/authorities/subjects/sh2005020175",
            "id": "sh2005020175",
            "label": "Citation of public records"
          },
          {
            "uri": "http://id.loc.gov/authorities/subjects/sh85083479",
            "id": [],
            "label": []
          },
          {
            "uri": "http://id.loc.gov/authorities/subjects/sh85056089",
            "id": [],
            "label": []
          },
          {
            "uri": "http://id.loc.gov/authorities/subjects/sh87004548",
            "id": [],
            "label": []
          },
          {
            "uri": "http://id.loc.gov/authorities/subjects/sh85104197",
            "id": [],
            "label": []
          },
          {
            "uri": "http://id.loc.gov/authorities/subjects/sh2008002683",
            "id": [],
            "label": []
          },
          {
            "uri": "http://id.loc.gov/authorities/subjects/sh85088469",
            "id": [],
            "label": []
          },
          {
            "uri": "http://id.loc.gov/authorities/subjects/sh85056058",
            "id": [],
            "label": []
          },
          {
            "uri": "http://id.loc.gov/authorities/subjects/sh85108692",
            "id": [],
            "label": []
          }
        ],
        "selectable": true,
        "drillable": true
      }
    ]
  },
  {
    "uri": "http://id.loc.gov/authorities/subjects/sh2005020175",
    "id": "http://id.loc.gov/authorities/subjects/sh2005020175",
    "label": "Citation of public records",
    "context": [
      {
        "property": "Preferred label",
        "values": [
          "Citation of public records"
        ],
        "selectable": true,
        "drillable": false
      },
      {
        "property": "Type",
        "values": [
          "http://www.loc.gov/mads/rdf/v1#Authority",
          "http://www.w3.org/2004/02/skos/core#Concept",
          "http://www.loc.gov/mads/rdf/v1#Topic"
        ],
        "selectable": false,
        "drillable": false
      },
      {
        "group": "Hierarchy",
        "property": "Broader",
        "values": [
          {
            "uri": "http://id.loc.gov/authorities/subjects/sh85108750",
            "id": "sh 85108750",
            "label": "Public records"
          },
          {
            "uri": "http://id.loc.gov/authorities/subjects/sh85013833",
            "id": [],
            "label": []
          }
        ],
        "selectable": true,
        "drillable": true
      }
    ]
  },
  {
    "uri": "http://id.loc.gov/authorities/subjects/sh85026790",
    "id": "http://id.loc.gov/authorities/subjects/sh85026790",
    "label": "Classification--Public records",
    "context": [
      {
        "property": "Preferred label",
        "values": [
          "Classification--Public records"
        ],
        "selectable": true,
        "drillable": false
      },
      {
        "property": "Type",
        "values": [
          "http://www.loc.gov/mads/rdf/v1#Authority",
          "http://www.w3.org/2004/02/skos/core#Concept",
          "http://www.loc.gov/mads/rdf/v1#ComplexSubject"
        ],
        "selectable": false,
        "drillable": false
      }
    ]
  }
]

So I'd suggest that this works correctly. If this seems like a data problem, then should ticket in QA. If additional work can be done to distinguish the two in the UI, then comment here.

@michelleif
Copy link

this one is a subdivision: http://id.loc.gov/authorities/subjects/sh2002006377
this one is a "Topic"
Screen Shot 2019-09-12 at 9 16 56 PM
: http://id.loc.gov/authorities/subjects/sh85108750

@sfolsom: should QA search of LCSH bring back entries that are only used as subdivisions?

@michelleif michelleif transferred this issue from LD4P/sinopia_editor Sep 13, 2019
@elrayle
Copy link
Member

elrayle commented May 12, 2020

It seems like the question here is whether there is extended context that can be shown to the user that lets them know the difference between the two results.

@sfolsom What is the action we need to take for this?

@elrayle elrayle added authority tests needs connection tests or accuracy tests for an authority cache Indexing Moderate Priority moderate priority - probably needed but not critical at this time qa configs work needs to happen at the qa config level labels May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authority tests needs connection tests or accuracy tests for an authority cache Indexing Moderate Priority moderate priority - probably needed but not critical at this time qa configs work needs to happen at the qa config level
Projects
None yet
Development

No branches or pull requests

4 participants