Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Satellite TLE_label and TLE_file not in default parameters? #44

Open
tbarchyn opened this issue May 17, 2023 · 1 comment
Open

Satellite TLE_label and TLE_file not in default parameters? #44

tbarchyn opened this issue May 17, 2023 · 1 comment
Assignees

Comments

@tbarchyn
Copy link
Contributor

TLE_label and TLE_file are satellite method specific parameters that govern the orbit of the satellite, defined here:

https://github.com/LDAR-Sim/LDAR_Sim/blob/master/USER_MANUAL.md#tle_file-satellite-only

They are not in the default method parameters here:

https://github.com/LDAR-Sim/LDAR_Sim/blob/master/LDAR_Sim/src/default_parameters/m_default.yml

They are labeled as 'optional' and of course only apply to satellite method. My inclination is to add them and run some tests to make sure they won't break any other methods (seems unlikely) and submit PR.

Was there specific reasoning why they weren't in the default parameters?

@SEAJang
Copy link
Contributor

SEAJang commented Jun 7, 2023

From my understanding, they were not added to the default parameters because they are only used for satellites, so it was determined users who want to parameterize satellites could always add these parameters.

Tests will definitely have to be done before these parameters are added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants