Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename DataType::Binary to DataType::Bytes #114

Closed
LDeakin opened this issue Dec 30, 2024 · 0 comments · Fixed by #118
Closed

Rename DataType::Binary to DataType::Bytes #114

LDeakin opened this issue Dec 30, 2024 · 0 comments · Fixed by #118
Labels
good first issue Good for newcomers
Milestone
zarrs 0.19

Comments

@LDeakin
Copy link
Owner

LDeakin commented Dec 30, 2024 •
edited
Loading

The implementation of variable-length data types in zarrs was based on ZEP0007, which used Binary for variable length binary data. That ZEP has stalled and zarr-python has opted to use Bytes instead and to use the vlen-bytes codec name. So, just rename this data type for ecosystem compatibility.
@LDeakin LDeakin added this to the zarrs 0.19 milestone Dec 30, 2024
@LDeakin LDeakin added the good first issue Good for newcomers label Dec 30, 2024
LDeakin added a commit that referenced this issue Jan 1, 2025
@LDeakin
refactor!: rename binary data type to bytes
ca9ba4e 
closes #114
LDeakin added a commit that referenced this issue Jan 1, 2025
@LDeakin
refactor!: rename binary data type to bytes
6f99887 
closes #114
@LDeakin LDeakin mentioned this issue Jan 1, 2025
Merged
@LDeakin LDeakin closed this as completed in 698fb83 Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
zarrs 0.19
Development

Successfully merging a pull request may close this issue.

refactor!: rename binary data type to bytes LDeakin/zarrs
1 participant
@LDeakin