Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on ng serve due to missing files #38

Open
alexdefelipe opened this issue Feb 28, 2022 · 5 comments
Open

Error on ng serve due to missing files #38

alexdefelipe opened this issue Feb 28, 2022 · 5 comments

Comments

@alexdefelipe
Copy link

I was having trouble on deploying the app because down_arrow_gray_10_10.png and magnifying_glass.png files where missing. Adding these two elements to filePathMap object on copy-lforms.js solved the issue:

  'webcomponent/down_arrow_gray_10_10.png': 'elements',
  'webcomponent/magnifying_glass.png': 'elements',
@plynchnlm
Copy link
Member

We're having trouble reproducing this. When you run the app without that change, are you seeing fields that should be displaying those images but are not? Or, what is the indication you are seeing that those images are missing?

@alexdefelipe
Copy link
Author

I've tried to reproduce the issue again, but I haven't managed either...

I can't remember the details. I remember that Angular was throwing an error, so I couldn't use the app. The styles.css content was displayed as part of the error both in the browser and in the terminal where I was launching the process, and in the Network tab of the Google Chrome's DevTools I could see that, when trying to download those files from Angular's dev server, it returned a 404. That's why I acknowledged the existance of those files and was able to download them from https://clinicaltables.nlm.nih.gov/lforms-versions/30.0.0-beta.2/webcomponent.

Sorry for the inconvenience. By the way, I expected this repo to hold the app deployed here: https://lhcformbuilder.nlm.nih.gov/, but I'm getting this one instead, which is missing some funcionalities and its appearence is different. Am I missing something?

image

@plynchnlm
Copy link
Member

That is a screenshot of the new "beta" version we are hoping to release soon. I would be interested to hear more about what missing functionality is something you need. If you want the version that is currently live, try version 6.5.2.
We probably should have indicated the beta status in the 7.x version numbers, but we were not expecting the beta status to last so long. Basically, we are trying to fix some bugs before making the new version live.

@alexdefelipe
Copy link
Author

In version 7.x I can't figure out how to configure an item for an observation-based population. In version 6.5.1 it's crystal clear:
image

I can't figure out either how to configure an item for an expression-based population, neither in version 6.5.1 nor 7.x. I guess this population mechanism isn't supported by the formbuilder, am I right? This might be the functionality I'm more interested in.

Regarding minor functionalities, I think setting an item as a group was nicer in the live version. I also miss the item options that let me handle them: insert items, move them, etc. I know I still can handle it with the drag and drop tool, but I think having both of them was really handy.

So the fact that, apparently, the live version has got more features than the 7.x and that its appearance is, in my opinion, nicer, made me think it was the latest.

Still, I think this is a great tool overall. Thank you for your work! I'll wait for your comments.

@plynchnlm
Copy link
Member

Thanks for the pointing out that we missed Observation-based population. We will try to get that added before we go live with the new version. Thanks also for the feedback about the setting an item to be a group. We were trying to avoid having two ways to do that, but I agree that it the drag-drop method is not as obvious.

The initial motivation for this rewrite was to move off of AngularJS, which is no longer being supported, and we took advantage of the rewrite to revise the UI. The whole process has taken much longer than anticipated, and we are trying to get the new version live with at least the same functionality as existed in the old one, before turning to adding new features. We are planning to keep the old version around for a while after releasing the new version, and to provide a link to get to it, but eventually I think there will be some important security issue we can't fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants