Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle static-only HDF5 library #140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

markcmiller86
Copy link
Member

Resolves #137

  • Added logic to config.make to detect if libhdf5.{so,dylib,dll} is present in HDF5_LIB directory. If it is NOT, plugin tests are disabled.
  • Added a line to documentation about installing HDF5 to not use --disable-shared configuration.

@jhendersonHDF
Copy link
Contributor

I thought a bit more about this PR. Since the 1.14.4 release of HDF5 will remove the "-shared" tools and link to the shared lib by default, I think the current check will be correct, but this also should first check if the "-shared" tool is present. If it is, either run the test with that or skip it (since the other-named tool will be statically linked). If it's not, then go ahead and perform the HDF5_IS_STATIC_ONLY check and skip the test if true. Another thing to take into account is that HDFGroup/hdf5#4046 adds a new HDF5_BUILD_STATIC_TOOLS CMake option to keep the old behavior when both static and shared libs are built. I don't really know how to handle that case here other than either checking if that option is set in HDF5's cmake configuration files, or figuring out how to determine a tool was statically linked with HDF5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unit test fails
2 participants