Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require downstream projects to enable OpenMP #1754

Open
rhornung67 opened this issue Oct 18, 2024 · 0 comments
Open

Don't require downstream projects to enable OpenMP #1754

rhornung67 opened this issue Oct 18, 2024 · 0 comments

Comments

@rhornung67
Copy link
Member

Is your feature request related to a problem? Please describe.

Currently, if a RAJA build is configured with OpenMP enabled, a downstream project using that build must also have OpenMP enabled. Otherwise, the downstream project build will fail. The reason is this line https://github.com/LLNL/RAJA/blob/develop/include/RAJA/config.hpp.in#L263

Describe the solution you'd like

Don't require a downstream project to have OpenMP enabled if building against RAJA with OpenMP enabled. This would be consistent with how other back-ends in RAJA are handled. For example, we don't require CUDA to be enabled in a downstream project when built against RAJA with CUDA enabled.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

The conditional logic in the code linked above is likely a remnant from when RAJA had OpenMP enabled by default. In the recent past, this was changed so that OpenMP is treated the same as other back-ends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant