Host execution space can use more than just its default and unified m… #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunney1
added
bug
gunney1
requested review from
rhornung67,
publixsubfan,
bmhan12 and
Arlie-Capps
kennyweiss
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
Thanks @gunney1
Should we add any unit tests to exercise this?
rhornung67
approved these changes
Feb 20, 2025
|
@kennyweiss @rhornung67 I'm not sure what a non-trivial test would check. The code just returns what it's hard-coded to return. The error was my oversight when I wrote the original code. I just failed to account for all the memory spaces we supported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix what memory spaces SEQ_EXEC and OMP_EXEC claim to be able to use. They could use Dynamic and Host, not just their default memory space.