Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slic's LoggerStream should not require an ostream in the constructor #521

Open
kennyweiss opened this issue Apr 12, 2021 · 3 comments
Open
Assignees
Labels
bug Something isn't working Reviewed Slic Issues related to Axom's 'slic' component

Comments

@kennyweiss
Copy link
Member

kennyweiss commented Apr 12, 2021

The ostream is only used by the root rank, but is required for all ranks.
We shouldn't need to create an ostream on ranks that it is not used.
This is especially problematic for fstreams.

@white238 has a WIP branch for this:

Possibilities to resolve this:

  • we can break this out into two constructors -- one that takes an ostream and one that does not,
  • we can allow a nullptr for the ostream instance, and modify the class to deal with a nullptr
  • we can remove the ostream from the constructor and add a function to set the ostream pointer.
@kennyweiss kennyweiss added the Slic Issues related to Axom's 'slic' component label Apr 12, 2021
@rhornung67 rhornung67 added this to the FY22 Development milestone Oct 12, 2021
@rhornung67
Copy link
Member

I prefer the 3rd option above.

@kennyweiss kennyweiss modified the milestones: FY22 Development, FY23 Development Mar 20, 2023
@kennyweiss kennyweiss added the bug Something isn't working label Mar 20, 2023
@kennyweiss kennyweiss modified the milestones: FY23 Development, FY24 Development Oct 26, 2023
@rhornung67
Copy link
Member

@white238 is this done?

@white238
Copy link
Member

white238 commented Dec 9, 2024

not that i can tell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Reviewed Slic Issues related to Axom's 'slic' component
Projects
None yet
Development

No branches or pull requests

3 participants