You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Saltatlas DHNSW executables can no longer compile due to the following error:
603 | cereal::YGMOutputArchive oarchive(to_return); // Create an output archive
| ^~~~~~~~
In file included from /Users/priest2/workspace/nisenemarks/repos/saltatlas/build/_deps/ygm-src/include/ygm/comm.hpp:22,
from /Users/priest2/workspace/nisenemarks/repos/saltatlas/build/_deps/ygm-src/include/ygm/collective.hpp:8,
from /Users/priest2/workspace/nisenemarks/repos/saltatlas/build/_deps/ygm-src/include/ygm/container/detail/base_count.hpp:10,
from /Users/priest2/workspace/nisenemarks/repos/saltatlas/build/_deps/ygm-src/include/ygm/container/bag.hpp:12,
from /Users/priest2/workspace/nisenemarks/repos/saltatlas/include/saltatlas/dhnsw/detail/utility.hpp:11,
from /Users/priest2/workspace/nisenemarks/repos/saltatlas/examples/dhnsw_big_ann.cpp:2:
/Users/priest2/workspace/nisenemarks/repos/saltatlas/build/_deps/ygm-src/include/ygm/detail/ygm_cereal_archive.hpp:46:3: note: candidate: 'cereal::YGMOutputArchive::YGMOutputArchive(ygm::detail::byte_vector&)'
46 | YGMOutputArchive(ygm::detail::byte_vector &stream)
| ^~~~~~~~~~~~~~~~
/Users/priest2/workspace/nisenemarks/repos/saltatlas/build/_deps/ygm-src/include/ygm/detail/ygm_cereal_archive.hpp:46:46: note: no known conversion for argument 1 from 'std::vector<std::byte>' to 'ygm::detail::byte_vector&'
46 | YGMOutputArchive(ygm::detail::byte_vector &stream)
| ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
This appears to happen because saltatlas::dhnsw::detail::query_engine reasons about raw std::vector<std::byte> buffers. Meanwhile, it appears that a recent commit to ygm/v0.7-dev (520916642aab511ce7261801812f5f10b88f8ee6) updated YGM to internally use ygm::detail::byte_vector. This means that cereal::YGMOutputArchive can no longer accept a raw std::vector<std::byte> in its constructor.
I fiddled with a few simple fixes, but I think that either ygm::detail::byte_vector needs to have const iterator accessors and an interface for inserting new bytes, or there need to be major changes made to saltatlas::dhnsw::detail::query_engine.
The text was updated successfully, but these errors were encountered:
Saltatlas DHNSW executables can no longer compile due to the following error:
This appears to happen because
saltatlas::dhnsw::detail::query_engine
reasons about rawstd::vector<std::byte>
buffers. Meanwhile, it appears that a recent commit toygm/v0.7-dev
(520916642aab511ce7261801812f5f10b88f8ee6) updated YGM to internally useygm::detail::byte_vector
. This means thatcereal::YGMOutputArchive
can no longer accept a rawstd::vector<std::byte>
in its constructor.I fiddled with a few simple fixes, but I think that either
ygm::detail::byte_vector
needs to have const iterator accessors and an interface for inserting new bytes, or there need to be major changes made tosaltatlas::dhnsw::detail::query_engine
.The text was updated successfully, but these errors were encountered: