Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect error message occurs when flush operation is done to empty file #477

Open
ddai-pl opened this issue Feb 9, 2022 · 1 comment

Comments

@ddai-pl
Copy link

ddai-pl commented Feb 9, 2022

Propose a fix as shown below.

In c file: ./src/scr_flush_file.c
@@ -405,9 +405,10 @@ int main (int argc, char *argv[])
/* read in our flush file /
if (kvtree_read_path(file_path, hash) != KVTREE_SUCCESS) {
/
failed to read the flush file */
// scr_err("%s: Failed to read flush file '%s' @ %s:%d",
// PROG, file_path, FILE, LINE
// );
char *path_str = spath_strdup(file_path);
scr_warn("%s: Failed to read flush file %s @ %s:%d",
PROG, path_str, FILE, LINE);
free(path_str);
goto cleanup;
}

@adammoody
Copy link
Contributor

Thanks, @ddai-pl . I've included your fix here:

50f37cf

I tested that this compiled, but I haven't tested it at runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants