Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests generate errors #64

Open
atherdon opened this issue Jun 19, 2022 · 7 comments
Open

tests generate errors #64

atherdon opened this issue Jun 19, 2022 · 7 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@atherdon
Copy link
Contributor

atherdon commented Jun 19, 2022

i copy-pasted tests from our main repository.

https://github.com/LLazyEmail/generator-module/blob/main/tests/methods/utils.test.js

6 months ago this module was a part of our monolithic project and we start to drown with issues, related to our tech debt.
So I moved away our simple functionality here. Our goal is to make tests executable because a few days ago I set up Github Actions for improving our code quality.

@atherdon atherdon added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jun 19, 2022
@atherdon
Copy link
Contributor Author

image

@atherdon
Copy link
Contributor Author

List of crashed actions located here: https://github.com/LLazyEmail/generator-module/actions

@C-Y-P-H-E-R
Copy link

the utils directory was missing in the code provided to me.
is it available on some different branch ?

@atherdon
Copy link
Contributor Author

Opening right now.

@atherdon
Copy link
Contributor Author

fixing paths right now, changes will appear in the main branch
but I think we also need to fix babel-eslint here, as you advised in _trying-lit repository

btw, you can fork this repo and later submit changes via pull requests.

@atherdon
Copy link
Contributor Author

here is a new error that i'm getting right now

image

i need to run home, will be able to debug it later

cc @C-Y-P-H-E-R

@C-Y-P-H-E-R
Copy link

fixing paths right now, changes will appear in the main branch but I think we also need to fix babel-eslint here, as you advised in _trying-lit repository

btw, you can fork this repo and later submit changes via pull requests.

Okay!
Kindly do update me about the changes, so that i can pull those on time and avoid merge-related issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants