Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save a bank name list into Structura #215

Closed
38 tasks done
Yann-BUTSCHER-EIRL opened this issue Jul 6, 2020 · 4 comments
Closed
38 tasks done

Save a bank name list into Structura #215

Yann-BUTSCHER-EIRL opened this issue Jul 6, 2020 · 4 comments
Assignees
@hundrex
Labels
Enhancement New feature or request Scheduled This commit will be solved in an upcoming version

Comments

@Yann-BUTSCHER-EIRL
Copy link
Collaborator

Yann-BUTSCHER-EIRL commented Jul 6, 2020 •
edited by LucileDT
Loading

Context

When someone pay by check we need to identify the check's bank. For this we need a list for bank names that is saved in the application.

Todo

  • Add a new entity "Bank" with the following fields
    • id : int - primary key
    • name : string - unique - required
  • Add bank select on forms
    • donation
      • creation
        • show when payment type is check
        • hide on other payment types
          • hidden by default
          • hidden when selected
      • edition
        • show when payment type is check
        • hide on other payment types
          • hidden by default
          • hidden when selected
    • membership
      • creation
        • show when payment type is check
        • hide on other payment types
          • hidden by default
          • hidden when selected
      • edition
        • show when payment type is check
        • hide on other payment types
          • hidden by default
          • hidden when selected
  • Show bank in detail pages
    • membership show
    • donation show
  • Add CRU pages in Administration to save new Banks
    • create
    • show
    • update

Additionally (we need to change our select library):

  • replace bootstrap select by Select2 on forms where it's used
    • membership creation form
    • membership edition form
    • donation creation form
    • donation edition form
@Yann-BUTSCHER-EIRL Yann-BUTSCHER-EIRL added the Enhancement New feature or request label Jul 6, 2020
@Yann-BUTSCHER-EIRL Yann-BUTSCHER-EIRL mentioned this issue Jul 6, 2020
Closed
7 tasks
@Yann-BUTSCHER-EIRL Yann-BUTSCHER-EIRL added the Scheduled This commit will be solved in an upcoming version label Jul 6, 2020
@LucileDT LucileDT self-assigned this Jul 7, 2020
LucileDT added a commit that referenced this issue Jul 10, 2020
@LucileDT
Ref #215: create Bank entity
2897b25
LucileDT added a commit that referenced this issue Jul 11, 2020
@LucileDT
Ref #215: add Select2 library
15b5db4
LucileDT added a commit that referenced this issue Jul 11, 2020
@LucileDT
Ref #215: setup Select2 to work with data-toggle attribute
f8d6a49
LucileDT added a commit that referenced this issue Jul 11, 2020
@LucileDT
Ref #215: style Select2 elements to look like Bootstrap 4 theme
496319b
LucileDT added a commit that referenced this issue Jul 11, 2020
@LucileDT
Ref #215: use Select2 in donation creation&edit forms
4c90c2d
LucileDT added a commit that referenced this issue Jul 11, 2020
@LucileDT
Ref #215: add Bank entity
eeb7fee
LucileDT added a commit that referenced this issue Jul 12, 2020
@LucileDT
Ref #215: replace bootstrap-select by select2 in membership creation&…
d639850 
…edition forms
LucileDT added a commit that referenced this issue Jul 12, 2020
@LucileDT
Ref #215: add bank to payment
054022e
LucileDT added a commit that referenced this issue Jul 12, 2020
@LucileDT
Ref #215: create bank fixtures and update existing payments
785ad21
LucileDT added a commit that referenced this issue Jul 12, 2020
@LucileDT
Ref #215: add bank select on membership edit&create forms
cc20cd0
LucileDT added a commit that referenced this issue Jul 16, 2020
@LucileDT
Ref #215: check if bank information is needed when setting one to a p…
d826384 
…ayment
LucileDT added a commit that referenced this issue Jul 16, 2020
@LucileDT
Update fixtures:
8362be3 
- #215: remove bank information where not needed
- add more donations
- rework of payment dates to be able to diplay nice stats on home page
LucileDT added a commit that referenced this issue Jul 16, 2020
@LucileDT
Ref #215: set to null bank information if payment type does not need …
e78d740 
…it on membership creation&edition
LucileDT added a commit that referenced this issue Jul 16, 2020
@LucileDT
Ref #215: hide/show bank selector if payment needs it in membership e…
f40ca95 
…dition&create forms
@LucileDT
Copy link
Member

LucileDT commented Dec 13, 2020 •
edited
Loading

@Yann-BUTSCHER-EIRL I think making the bank creation available in the dropdown is too difficult for now. I propose we add some regular CRUD pages for it as it will be faster to make and easier to maintain.

@Yann-BUTSCHER-EIRL
Copy link
Collaborator Author

@LucileDT It's ok for me but we need to create an issue for the dropdown later realisation.

@LucileDT
Copy link
Member

I'll let you do it.

@Yann-BUTSCHER-EIRL Yann-BUTSCHER-EIRL mentioned this issue Dec 13, 2020
Open
10 tasks
@Yann-BUTSCHER-EIRL
Copy link
Collaborator Author

Created the issue #237.
Updated the todo list and the context accordingly.

LucileDT added a commit that referenced this issue Dec 13, 2020
@LucileDT
Ref #215: remove a forgotten debug command
4aa9242
LucileDT added a commit that referenced this issue Dec 13, 2020
@LucileDT
Ref #215: save comments into payment
633fa7c
LucileDT added a commit that referenced this issue Dec 13, 2020
@LucileDT
Ref #215: show bank name when there is one defined
19f089f
LucileDT added a commit that referenced this issue Dec 13, 2020
@LucileDT
Ref #215: remove code added by error
629a710
LucileDT added a commit that referenced this issue Dec 13, 2020
@LucileDT
Ref #215: show bank selector in donation form when payment type is check
6790fa2
LucileDT added a commit that referenced this issue Dec 13, 2020
@LucileDT
Ref #215: save bank on donation creation and edition
b151047
LucileDT added a commit that referenced this issue Dec 13, 2020
@LucileDT
Ref #215: fix error preventing form saving memberships not payed by c…
86e9dff 
…heck
LucileDT added a commit that referenced this issue Dec 14, 2020
@LucileDT
Ref #215: add Bank CRUD in administration panel
c4b1a6c
@LucileDT LucileDT assigned hundrex and unassigned LucileDT Dec 14, 2020
LucileDT added a commit that referenced this issue Dec 20, 2020
@LucileDT
Ref #215: add missing use mention
ef52212
@hundrex hundrex closed this as completed Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hundrex hundrex

Labels
Enhancement New feature or request Scheduled This commit will be solved in an upcoming version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hundrex @LucileDT @Yann-BUTSCHER-EIRL