Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the people form in order to better manage data validation #319

Open
4 tasks
Yann-BUTSCHER-EIRL opened this issue Apr 6, 2023 · 1 comment
Open
4 tasks
Labels
Enhancement New feature or request

Comments

@Yann-BUTSCHER-EIRL
Copy link
Collaborator

Context

Recently we got multiple user feedback stating that the people form (create or edit) was not working properly.

One of the main reason is that each time the submitted data are not well formatted there is no front-end warning is shown to the user and no consistent error management is done when validating data in the back-end.

Reworking the entire form and way of asserting data constraints is a lot of work but I would be beneficial and might save time in the future (with less bug fixing).

Todo

  • Update the PeopleType form to add front-end validation.
  • Add back-end validation with a better entity mapping (see https://symfony.com/doc/4.4/validation.html)
  • Add try/catch block when creating a people
    • This will prevent uncaught exceptions that blocks the user
    • This will also help having a better way of logging exceptions
  • Same thing when updating a people
@LucileDT
Copy link
Member

LucileDT commented Apr 6, 2023

I agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants