Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Value::VarChar to Xml #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rename Value::VarChar to Xml #4

wants to merge 1 commit into from

Conversation

Xiphoseer
Copy link
Collaborator

@Xiphoseer Xiphoseer commented Jan 1, 2022 •
edited
Loading

This is a breaking change, please make sure your dependencies are pinned.

@Xiphoseer
Copy link
Collaborator Author

Any comments @enteryournamehere or @Jettford ?

@enteryournamehere
Copy link
Member

Changes look good, I suppose Xml makes more sense if that is the only thing it's ever used for. Will make sure to account for this when updating sqlite-to-fdb (once this is merged). (Also interesting git history you got there on this PR 👀)

@Jettford
Copy link
Contributor

Any comments @enteryournamehere or @Jettford ?

I guess better late then never but LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xiphoseer @enteryournamehere @Jettford