Skip to content

Commit edfdc4b

Browse files
Update labkeyVersion to 25.3.5
2 parents cc7998b + f7fe8d4 commit edfdc4b

File tree

2 files changed

+18
-5
lines changed

2 files changed

+18
-5
lines changed

gradle.properties

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ buildFromSource=true
4444

4545
# The default version for LabKey artifacts that are built or that we depend on.
4646
# override in an individual module's gradle.properties file as necessary
47-
labkeyVersion=25.3.4
47+
labkeyVersion=25.3.5
4848
labkeyClientApiVersion=6.2.0
4949

5050
# Version numbers for the various binary artifacts that are included when

server/embedded/src/org/labkey/embedded/EmbeddedExtractor.java

+17-4
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,9 @@ public void extractExecutableJar(File destDirectory, boolean remotePipeline)
224224
{
225225
try (JarFile jar = new JarFile(verifyJar()))
226226
{
227-
boolean foundDistributionZip = false;
227+
boolean missingDistributionZip = true;
228+
boolean missingBootstrapJar = remotePipeline;
229+
boolean missingServletApiJar = remotePipeline;
228230
var entries = jar.entries();
229231
while (entries.hasMoreElements())
230232
{
@@ -233,22 +235,24 @@ public void extractExecutableJar(File destDirectory, boolean remotePipeline)
233235

234236
if ("labkey/distribution.zip".equals(entryName))
235237
{
236-
foundDistributionZip = true;
238+
missingDistributionZip = false;
237239
try (var distInputStream = jar.getInputStream(entry))
238240
{
239241
extractDistributionZip(distInputStream, destDirectory);
240242
}
241243
}
242244
if (remotePipeline)
243245
{
246+
// Keep this code in sync with org.labkey.pipeline.api.PipelineServiceImpl.extractBootstrapFromEmbedded()
244247
if (entry.getName().contains("labkeyBootstrap") && entry.getName().toLowerCase().endsWith(".jar"))
245248
{
246249
try (var in = jar.getInputStream(entry))
247250
{
248251
extractFile(in, new File(destDirectory, "labkeyBootstrap.jar"));
249252
}
253+
missingBootstrapJar = false;
250254
}
251-
if (entry.getName().contains("tomcat-servlet-api") && entry.getName().toLowerCase().endsWith(".jar"))
255+
if (entry.getName().contains("tomcat-embed-core") && entry.getName().toLowerCase().endsWith(".jar"))
252256
{
253257
File pipelineLib = new File(destDirectory, "pipeline-lib");
254258
if (!pipelineLib.exists())
@@ -262,14 +266,23 @@ public void extractExecutableJar(File destDirectory, boolean remotePipeline)
262266
{
263267
extractFile(in, new File(pipelineLib, "servletApi.jar"));
264268
}
269+
missingServletApiJar = false;
265270
}
266271
}
267272
}
268273

269-
if (!foundDistributionZip)
274+
if (missingDistributionZip)
270275
{
271276
throw new ConfigException("Unable to find distribution zip required to run LabKey Server.");
272277
}
278+
if (missingBootstrapJar)
279+
{
280+
throw new ConfigException("Unable to find labkeyServer.jar required to run LabKey Server's remote pipeline code.");
281+
}
282+
if (missingServletApiJar)
283+
{
284+
throw new ConfigException("Unable to find Servlet API file required to run LabKey Server's remote pipeline code.");
285+
}
273286
}
274287
}
275288
catch (IOException | ConfigException e)

0 commit comments

Comments
 (0)