-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LibWeb+LibWebView: Use system font for Mathematical symbols and operators. #2333
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome! Change looks good, I'll just run CI to make sure.
a543306
to
8aaa932
Compare
Adds math symbols rendering support on linux (if it has "Noto Sans Math" font).
Include the Noto Sans Math font in the CI environment to support tests using mathematical characters. With the update to include the math font in the font cascade list, this dependency is now required. Added the Noto Sans Math package for Linux, Android, and macOS CI environments.
Sorry for the mess in this PR. I belive the test failed because the CI env does not have the math font installed. I have added it to the setup. |
Your layout test is missing after your latest push. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
@nico-engels Could you rebase on top of |
Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
This pull request has been closed because it has not had recent activity. Feel free to open a new pull request if you wish to still contribute these changes. Thank you for your contributions! |
Adds math symbols rendering support on linux (if it has "Noto Sans Math" font). Closes #2332
The change broke the test
css-text-transform-math-auto.html
, but fixes the exibition:before

after

The test was adjusted accordingly.