Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibWeb+LibWebView: Use system font for Mathematical symbols and operators. #2333

Closed

Conversation

nico-engels
Copy link

Adds math symbols rendering support on linux (if it has "Noto Sans Math" font). Closes #2332

The change broke the test css-text-transform-math-auto.html, but fixes the exibition:

before
image

after
image

The test was adjusted accordingly.

Copy link
Member

@AtkinsSJ AtkinsSJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! Change looks good, I'll just run CI to make sure.

Adds math symbols rendering support on linux (if it has "Noto Sans
Math" font).
Include the Noto Sans Math font in the CI environment to support
tests using mathematical characters. With the update to include
the math font in the font cascade list, this dependency is now
required.

Added the Noto Sans Math package for Linux, Android, and macOS CI
environments.
@nico-engels nico-engels reopened this Nov 23, 2024
@nico-engels
Copy link
Author

Sorry for the mess in this PR. I belive the test failed because the CI env does not have the math font installed. I have added it to the setup.

@nico-engels nico-engels requested a review from AtkinsSJ November 23, 2024 23:14
@tcl3
Copy link
Member

tcl3 commented Nov 24, 2024

Your layout test is missing after your latest push.

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

@github-actions github-actions bot added the stale label Dec 16, 2024
@gmta
Copy link
Collaborator

gmta commented Dec 20, 2024

@nico-engels Could you rebase on top of master? CI checks are currently in limbo because of some older CI rules.

@github-actions github-actions bot removed the stale label Dec 21, 2024
Copy link

Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest master.

@github-actions github-actions bot added the conflicts Pull request has merge conflicts that need resolution label Dec 22, 2024
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

@github-actions github-actions bot added the stale label Jan 13, 2025
Copy link

This pull request has been closed because it has not had recent activity. Feel free to open a new pull request if you wish to still contribute these changes. Thank you for your contributions!

@github-actions github-actions bot closed this Jan 21, 2025
@nico-engels nico-engels deleted the math-default-font branch February 3, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts Pull request has merge conflicts that need resolution stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unicode Math Symbols not rendering properly
4 participants