From e45ec0f6fab3f1783645b5fd7395016581f032ef Mon Sep 17 00:00:00 2001
From: Kyriakos Sidiropoulos <kyriakos.sidiropoulos@laerdal.com>
Date: Thu, 23 May 2024 17:52:55 +0200
Subject: [PATCH 1/2] feat (Laerdal.Dfu.Bindings.iOS.csproj): switch over to
 net8-ios

---
 Laerdal.Dfu.Bindings.iOS/Laerdal.Dfu.Bindings.iOS.csproj | 2 +-
 Laerdal.Scripts/Laerdal.SetupBuildEnvironment.sh         | 3 +--
 global.json                                              | 7 +++++++
 3 files changed, 9 insertions(+), 3 deletions(-)
 create mode 100644 global.json

diff --git a/Laerdal.Dfu.Bindings.iOS/Laerdal.Dfu.Bindings.iOS.csproj b/Laerdal.Dfu.Bindings.iOS/Laerdal.Dfu.Bindings.iOS.csproj
index 0d95ea2..b1eb864 100644
--- a/Laerdal.Dfu.Bindings.iOS/Laerdal.Dfu.Bindings.iOS.csproj
+++ b/Laerdal.Dfu.Bindings.iOS/Laerdal.Dfu.Bindings.iOS.csproj
@@ -9,7 +9,7 @@
     </PropertyGroup>
 
     <PropertyGroup>
-        <TargetFramework>net7.0-ios</TargetFramework>
+        <TargetFramework>net8.0-ios</TargetFramework>
 
         <MtouchExtraArgs>-v -v -v -v</MtouchExtraArgs>
 
diff --git a/Laerdal.Scripts/Laerdal.SetupBuildEnvironment.sh b/Laerdal.Scripts/Laerdal.SetupBuildEnvironment.sh
index 55f51ed..58e595b 100755
--- a/Laerdal.Scripts/Laerdal.SetupBuildEnvironment.sh
+++ b/Laerdal.Scripts/Laerdal.SetupBuildEnvironment.sh
@@ -76,8 +76,7 @@ dotnet                                \
              install                  \
                  maui                 \
                  ios                  \
-                 maui-ios             \
-                 wasm-tools-net7
+                 maui-ios
 #                    --from-rollback-file=https://maui.blob.core.windows.net/metadata/rollbacks/${dotnet_8_workload_version}.json   # we need to install additional packages manually
 declare exitCode=$?
 if [ $exitCode != 0 ]; then
diff --git a/global.json b/global.json
new file mode 100644
index 0000000..3639463
--- /dev/null
+++ b/global.json
@@ -0,0 +1,7 @@
+{
+  "sdk": {
+    "version": "8.0.0",
+    "rollForward": "latestFeature",
+    "allowPrerelease": false
+  }
+}

From 65c9be48838ec88d155bc7bd20f2c3e56024e2df Mon Sep 17 00:00:00 2001
From: Kyriakos Sidiropoulos <kyriakos.sidiropoulos@laerdal.com>
Date: Thu, 23 May 2024 23:31:21 +0200
Subject: [PATCH 2/2] fix (Laerdal.Dfu.Bindings.iOS.csproj): use
 Optimized=false to workaround a bug in net8 which is causing maui apps to
 crash upon getting launched in iPhones

    this wasnt necessary in net7 but somehow it became crucial under net8 (go figure ...)
---
 .../Laerdal.Dfu.Bindings.iOS.csproj             | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/Laerdal.Dfu.Bindings.iOS/Laerdal.Dfu.Bindings.iOS.csproj b/Laerdal.Dfu.Bindings.iOS/Laerdal.Dfu.Bindings.iOS.csproj
index b1eb864..169b2a9 100644
--- a/Laerdal.Dfu.Bindings.iOS/Laerdal.Dfu.Bindings.iOS.csproj
+++ b/Laerdal.Dfu.Bindings.iOS/Laerdal.Dfu.Bindings.iOS.csproj
@@ -10,18 +10,21 @@
 
     <PropertyGroup>
         <TargetFramework>net8.0-ios</TargetFramework>
-
-        <MtouchExtraArgs>-v -v -v -v</MtouchExtraArgs>
-
         <IsBindingProject>true</IsBindingProject>
 
+        <IsOSX Condition="      '$([System.Runtime.InteropServices.RuntimeInformation]::IsOSPlatform($([System.Runtime.InteropServices.OSPlatform]::OSX)))'     == 'true' ">true</IsOSX>
+    </PropertyGroup>
+    
+    <PropertyGroup>
+        <DebugType>full</DebugType>
+        <Optimized>false</Optimized>
+        <MtouchExtraArgs>-v -v -v -v</MtouchExtraArgs>
         <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
-        <MtouchNoSymbolStrip>true</MtouchNoSymbolStrip>
-
-        <!-- https://github.com/Laerdal/Laerdal.Dfu/issues/29#issuecomment-1904057544 -->
         <NoBindingEmbedding>true</NoBindingEmbedding>
+        <MtouchNoSymbolStrip>true</MtouchNoSymbolStrip>
 
-        <IsOSX Condition="      '$([System.Runtime.InteropServices.RuntimeInformation]::IsOSPlatform($([System.Runtime.InteropServices.OSPlatform]::OSX)))'     == 'true' ">true</IsOSX>
+        <!-- 1. under net8 we need Optimized=false otherwise release builds cause the resulting apps to crash right upon getting launched in the iphone! -->
+        <!-- 2. NoBindingEmbedding=true per https://github.com/Laerdal/Laerdal.Dfu/issues/29#issuecomment-1904057544 -->
     </PropertyGroup>
 
     <!-- ==================== VERSION ==================== -->