refa (DfuInstallation::OnProgressChanged()): we now emit errors using WriteLineAsync() for the sake of performance

ksidirop-laerdal · ksidirop-laerdal · commit 3a7f459078c8 · 2025-02-26T13:19:48.000+01:00
diff --git a/Laerdal.Dfu/DfuInstallation.cs b/Laerdal.Dfu/DfuInstallation.cs
@@ -207,7 +207,7 @@ internal void OnProgressChanged(double progress, double currentSpeedBytesPerSeco
             {
                 try
                 {
-                    Console.Error.WriteLine($"[DI.OPC.010] [DfuInstallation.OnProgressChanged()] [BUG] Suppressed internal bug while trying to calculate progress - report this incident!\n\n{ex}");
+                    Console.Error.WriteLineAsync($"[DI.OPC.010] [DfuInstallation.OnProgressChanged()] [BUG] Suppressed internal bug while trying to calculate progress - report this incident!\n\n{ex}");
                 }
                 catch
                 {
@@ -224,7 +224,7 @@ internal void OnProgressChanged(double progress, double currentSpeedBytesPerSeco
             {
                 try
                 {
-                    Console.Error.WriteLine($"[DI.OPC.020] [DfuInstallation.OnProgressChanged()::ProgressChangedEvent] [USERLAND BUG - SUPPRESSED] Error while raising event ProgressChanged - report this incident!\n\n{ex}");
+                    Console.Error.WriteLineAsync($"[DI.OPC.020] [DfuInstallation.OnProgressChanged()::ProgressChangedEvent] [USERLAND BUG - SUPPRESSED] Error while raising event ProgressChanged - report this incident!\n\n{ex}");
                 }
                 catch
                 {

Original file line number	Diff line number	Diff line change
`@@ -207,7 +207,7 @@ internal void OnProgressChanged(double progress, double currentSpeedBytesPerSeco`
`207`	`207`	`{`
`208`	`208`	`try`
`209`	`209`	`{`
`210`		`- Console.Error.WriteLine($"[DI.OPC.010] [DfuInstallation.OnProgressChanged()] [BUG] Suppressed internal bug while trying to calculate progress - report this incident!\n\n{ex}");`
	`210`	`+ Console.Error.WriteLineAsync($"[DI.OPC.010] [DfuInstallation.OnProgressChanged()] [BUG] Suppressed internal bug while trying to calculate progress - report this incident!\n\n{ex}");`
`211`	`211`	`}`
`212`	`212`	`catch`
`213`	`213`	`{`
`@@ -224,7 +224,7 @@ internal void OnProgressChanged(double progress, double currentSpeedBytesPerSeco`
`224`	`224`	`{`
`225`	`225`	`try`
`226`	`226`	`{`
`227`		`- Console.Error.WriteLine($"[DI.OPC.020] [DfuInstallation.OnProgressChanged()::ProgressChangedEvent] [USERLAND BUG - SUPPRESSED] Error while raising event ProgressChanged - report this incident!\n\n{ex}");`
	`227`	`+ Console.Error.WriteLineAsync($"[DI.OPC.020] [DfuInstallation.OnProgressChanged()::ProgressChangedEvent] [USERLAND BUG - SUPPRESSED] Error while raising event ProgressChanged - report this incident!\n\n{ex}");`
`228`	`228`	`}`
`229`	`229`	`catch`
`230`	`230`	`{`