Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw error if used on other websites #5

Closed
npalladium opened this issue Oct 2, 2019 · 2 comments · May be fixed by #16
Closed

Throw error if used on other websites #5

npalladium opened this issue Oct 2, 2019 · 2 comments · May be fixed by #16
Labels
good first issue Good for newcomers

Comments

@npalladium
Copy link
Collaborator

Currently the Extension quietly fails and returns an empty timetable if used on other websites. It should throw an error if the URL does not match.
@npalladium npalladium added the good first issue Good for newcomers label Oct 2, 2019
shraiysh added a commit to shraiysh/AIMS-Helper-Chrome that referenced this issue Sep 2, 2020
@shraiysh
Showing an error message on invalid URLs. Solves LambdaIITH#5
749b570
@shraiysh shraiysh mentioned this issue Sep 2, 2020
Open
RachitKeertiDas added a commit that referenced this issue Jan 6, 2023
@RachitKeertiDas
Update manifest with required permissions
caaa7b3 
Remove unneeded storage,tabs permissions
Update host to matching schemes. Thanks to @kst164
This allows extension to be hidden on non-AIMS websites

Part of:
#5

Fixes:
#38
@RachitKeertiDas
Copy link
Contributor

RachitKeertiDas commented Jan 6, 2023 •
edited
Loading

We have now hidden the extension on websites not matching aims.iith.ac.in as of latest main. We can also throw a error in the extension prompt if required.

#16 or a modification of it will be needed for that.

@RachitKeertiDas
Copy link
Contributor

On second thought, I actually think the current solution should be fine. Chrome explicitly tells the user that the extension will not be able to access information, and not be usable if clicked on another side.

Hence, I'm closing this for now. Feel free to reopen if you feel the current solution is inadequate/needs major improvements. @npalladium

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Showing an error message on invalid URLs shraiysh/AIMS-Helper-Chrome
2 participants
@npalladium @RachitKeertiDas