Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking API docs if we use .mount() #7

Open
RachitKeertiDas opened this issue Jun 17, 2023 · 2 comments
Open

Breaking API docs if we use .mount() #7

RachitKeertiDas opened this issue Jun 17, 2023 · 2 comments

Comments

@RachitKeertiDas
Copy link
Contributor

RachitKeertiDas commented Jun 17, 2023

Issue in current backend as of PR #6

However, some issues remain:
using .mount() breaks the API Docs on /docs and redoc.
It's still accessible on /hostel/redoc and /grid/redoc

There is probably a better way to do this without creating separate mounts.

Originally posted by @RachitKeertiDas in #6 (comment)

@RachitKeertiDas
Copy link
Contributor Author

On a similar note, one should update API Documentation

@MistyRavager
Copy link
Collaborator

I saw the mounting part for the first time here, before this i had seen subroutes separated within "routes" directory with file names like subroute.py and fastAPI router initialized within each one of them and these routers called in main.py (don't remember exactly)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants