Minikube warn if Port Fowarding cannot start (#698) (#700)

Add error handling to the shell script function `start_port_forward` to avoid the current hanging if no *node port* is defined for the service. Doesn't attempt any alternate forwarding (eg kubectl), just gives a moderately helpful message and errors out. Co-authored-by: Nick Burch <[email protected]>
LangStream · Nov 8, 2023 · d362a02 · d362a02
1 parent 87f19a2
commit d362a02
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/mini-langstream/mini-langstream b/mini-langstream/mini-langstream
@@ -223,10 +223,15 @@ start_port_forward() {
   local service=$1
   local file=$(mktemp)
 
-  minikube_cmd service $1 --url -n $k8s_namespace &> $file &
-  grep -q 'http' <(tail -f $file)
-  url=$(grep -e http $file)
-  echo "$url"
+  minikube_cmd service $1 --url -n $k8s_namespace &> $file
+  if grep -q 'http' $file; then
+    url=$(grep -e http $file)
+    echo "$url"
+  else
+    echo "${service}: ❌ - Port forwarding failed to start" >&2
+    cat $file >&2
+    exit 1
+  fi
 }
 
 kafka_hostname=langstream-kafka