Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete arc #9

Open
zsoltk opened this issue Jan 7, 2016 · 1 comment
Open

Incomplete arc #9

zsoltk opened this issue Jan 7, 2016 · 1 comment

Comments

@zsoltk
Copy link

zsoltk commented Jan 7, 2016

I'm trying to implement my own ColorAdapter, and I found that sometimes the arc is incomplete. I'm guessing this is because in the implementation of LobsterPicker.getAngle(int position) segmentWidth is calculated using integer division:

int segmentWidth = 360 / nbOfSegments;

So when my adapter has 16 colors, 360 / 16 = 22.5 is treated as 22.

When I reduce the number of colors to 15 (360 / 15 = 24), the arc is complete.

See a screenshot here.

Thanks for the great library!

@LarsWerkman
Copy link
Owner

@zsoltk Yes I think that's the issue, Currently I'm totally out of time to fix this issue. A pull request is much appreciated.

zsoltk added a commit to zsoltk/Lobsterpicker that referenced this issue Jan 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants