Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace typealiases with value classes #18

Closed
LastExceed opened this issue May 31, 2021 · 1 comment · Fixed by #57
Closed

replace typealiases with value classes #18

LastExceed opened this issue May 31, 2021 · 1 comment · Fixed by #57
Labels
code quality Improve future proofness

Comments

@LastExceed
Copy link
Owner

for actual type safety

@LastExceed LastExceed added the code quality Improve future proofness label May 31, 2021
LastExceed added a commit that referenced this issue May 31, 2021
@LastExceed
Copy link
Owner Author

should dynamic endpoints be instantiable with both value class and underlying object ? if yes, then we'd need to overload the constructor which isnt possible because the JVM signature of the ctors would be identical, and the jvmname of a ctor cannot be altered via annotation. one way would be to implement operator fun invoke on the companion object but thats a huge smell. this problem probably wont exist anymore after #9 gets done though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improve future proofness
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant