Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update all main files with the same runtime_error exception handling #57

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

luhuhis
Copy link
Collaborator

@luhuhis luhuhis commented Feb 1, 2022

resolves #24

@clarkedavida
Copy link
Collaborator

Everything passes with CUDA 11.6 in this branch except the following:

  • DslashMulti
  • HBOR_multiple
  • hisqForce
  • hisqForceImagMu
  • rhmcTest
  • rhmcTest_4pf
    The first three are fixed in a0e0a5f, d5758b4, and d278c36, respectively. The last three presumably suffer from the same issue that hisqForce did with the introduction of CUDA 11.6?

@dbollweg
Copy link
Collaborator

dbollweg commented Feb 9, 2022

The issues with cuda 11.6 are unrelated to the changes introduced in this pr. I think we should be able to merge if everything passes on 11.0?

@clarkedavida
Copy link
Collaborator

I tend to agree with you, Dennis. Could either you or Lukas do the 11.0 tests and then merge it in if everything is fine?

@lukas-mazur
Copy link
Collaborator

I agree, I will run the tests

@lukas-mazur
Copy link
Collaborator

All tests (except the above mentioned tests) pass on single GPU.
However, since try-catch adds some overhead, it would be good if timing tests could be done, before we merge this branch. Just to be sure.

@luhuhis
Copy link
Collaborator Author

luhuhis commented Feb 14, 2022

I think someone already tested this some time ago (maybe @dbollweg ?), but I agree. Although I would be surprised if it there is was any difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using try/catch syntax
4 participants