Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: consider removing premake files from repo under tools/ #243

Open
diamante0018 opened this issue Sep 5, 2024 · 1 comment
Open
Labels
refactor Refactors an existing feature or system

Comments

@diamante0018
Copy link
Contributor

It's probably better that the end user has premake installed on their system somewhere and adds it to their path env

this eliminates the need to distribute premake5 binaries inside the repo

this is a similar choice I've taken when dealing with alterware's clients repo https://git.alterware.dev/alterware/iw4x-sp#build

@Laupetin
Copy link
Owner

Laupetin commented Sep 5, 2024

Definitely something that i want to address in the future.
I don't like the opaque binaries in the repository either.

The issue is that premake is not exactly easy to install because you must choose the containing folder yourself and add it to the path manually.
There is no automated installation process to do this.
This somewhat adds a barrier to compiling the project for more inexperienced developers.

What I could imagine is adding ontop of the generate.bat script to check whether a premake5 binary is in the path.
If it is not it could download the latest version (after a confirmation prompt) and add it to a folder similar to the current one.
That way it would not be in the repo but users would not need to manually install premake either.

@Laupetin Laupetin added the refactor Refactors an existing feature or system label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactors an existing feature or system
Projects
None yet
Development

No branches or pull requests

2 participants