-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signature Request Example #6
base: master
Are you sure you want to change the base?
Signature Request Example #6
Conversation
@@ -36,6 +36,11 @@ tokio = { version = "1.37.0", features = ["test-util", "full", "sync"] } | |||
futures = "0.3" | |||
chrono = "0.4" | |||
uuid = { version = "1.0", features = ["v4"] } | |||
eigen-crypto-bls = { git = "https://github.com/Layr-Labs/eigensdk-rs/" ,rev = "62556fdb5701dee5a30ea348e7a311be96ab051f"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this create a dependency on this package for pushing cerberus-api
crates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. Also a bug with the signature production currently, may be related to rust/go issues with encoding encrypted json keystores as previously discussed with @supernovahs. Alternatively, I suspect there may be a masking issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay - I don't think we want dependency on eigen-crypto-bls
lib on this - since this is just an example of using it - maybe there's a way to create a separate examples modules which has it's own deps.
yea - there's a difference between Go and Rust SDK on generating encrypted JSON. I need to fix it. but that should not create bugs since - cerberus and rust sdk creates same format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/RonTuretzky/cerberus-api/tree/bug/inconsistent_signing branch for recreation of the bug
https://www.loom.com/share/217262aa5a2647c6a958df2e9f72087e?sid=d537f0e6-0e9a-40aa-a74f-bd673d89f876 loom of the behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for the sake of completeness, support for the eigensdk-rs makes sense as AVS developers will opt into using that and will expect compatibility with Cerberus...
This PR introduces using the Cerberus Rust API to fetch a signature in conjunction with the eigensdk-rs library