Client implementation #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samlaf
reviewed
Nov 30, 2024
|
|
||
|
|
||
|
|
||
| anyhow = "1" #TODO: Remove |
There was a problem hiding this comment.
TODO: upstream lambdaclass#1
src/generated/disperser.rs
Outdated
There was a problem hiding this comment.
How are these files generated? We prob want eigenda repo as a submodule, and then use a build.rs to generate these files?
Comment on lines
+63
to
+70
| impl From<DisperserG1Commitment> for G1Commitment { | ||
| fn from(value: DisperserG1Commitment) -> Self { | ||
| Self { | ||
| x: value.x, | ||
| y: value.y, | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Is there any point in redefining G1Commitment here? Its literally the same struct as the one in generated/common.rs. Perhaps we can just use that one directly?
| /// URL of the Ethereum RPC server | ||
| pub eigenda_eth_rpc: String, | ||
| /// Address of the service manager contract | ||
| pub eigenda_svc_manager_address: String, |
There was a problem hiding this comment.
should we use https://docs.rs/alloy-primitives/latest/alloy_primitives/struct.Address.html instead of String?
| #[derive(Clone, Debug, PartialEq)] | ||
| pub enum PointsSource { | ||
| Path(String), | ||
| Link(String), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the client implementation coming from zksync-era.
It has some changes to make it work as a lib: