Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update explanation for batch-hash-mismatch bug (wrong for arb) #320

Open
samlaf opened this issue Feb 28, 2025 · 2 comments · May be fixed by #322
Open

docs: update explanation for batch-hash-mismatch bug (wrong for arb) #320

samlaf opened this issue Feb 28, 2025 · 2 comments · May be fixed by #322
Assignees

Comments

@samlaf
Copy link
Collaborator

samlaf commented Feb 28, 2025

The batch hash mistmatch bug explanation here is incomplete:

  1. this error is only possible for op: arb's sequencer inbox is a contract which would prevent the commitment from even landing on-chain in the case of a reorg that would change the confirmation-block-number
  2. even for the op case, I'm not 100% sure that the recent op-batcher wouldn't catch the reorg and resubmit a new blob. So might not be as important an issue as we've highlighted... need to confirm this with OP folks.

We should also add the example error at the top of the section:

t=2025-02-10T07:25:24+0000 lvl=info msg=request role=eigenda_proxy method=GET url=/get/0x010000f901d8f852f842a02da35fdbe4fed916eb80fafb6e12711a35327e1e7055b78fc9085812e9d6e28fa021c98859127f075fc90785a730ce1b3894586badee45a698a5cce9c2d6d36269820200cac480213701c401213708f901818302270581c3f873eba0eea9df513a56cbdc8a8c045ddaa61a2a7f86097ad0b99b5b08baa7119065effe82000182636283328734a0c7c898eb39076fbc6b367c51c1908a68bbcac3d81f739057aec168aa3a78e1b20083328792a0c3169896044de8cee3270fdd643157665353a6963149cb158b63137ac405251ab90100c3904bddb63b2be1f2e779b9ecf289fe40693eb943cb260a7d5c95ac6021f35883ade0e4d82e071b86158510fc83cd2c2d61f4a72e6bc6d5c533bacd44eb6a6b97f742d7518f6475f65fb0656fe58d8ad2cc8961c770680c9538593c5a8bc3861fc11e38477076f06911e6de93d9b641b535115700bcdcc863b58b021a7a177b3343e80ab645867061216e191740e4558754e7d13fc3f235743f8d865c0f976a91a3c7912d03e56bb955ddec854c2d661edfc43d5c366040296eac657960a8b40ec6e01b17624d18f32e930b8712cc1a00a2f696229ce10b5b03b3c7c992b601c8ef46390b2fd016687cd1ed4cd70310018dfa97418c7819a0cda7322a7eefa4820001 status=500 duration=585.735929ms err="Error: get request failed with commitment f901d8f852f842a02da35fdbe4fed916eb80fafb6e12711a35327e1e7055b78fc9085812e9d6e28fa021c98859127f075fc90785a730ce1b3894586badee45a698a5cce9c2d6d36269820200cac480213701c401213708f901818302270581c3f873eba0eea9df513a56cbdc8a8c045ddaa61a2a7f86097ad0b99b5b08baa7119065effe82000182636283328734a0c7c898eb39076fbc6b367c51c1908a68bbcac3d81f739057aec168aa3a78e1b20083328792a0c3169896044de8cee3270fdd643157665353a6963149cb158b63137ac405251ab90100c3904bddb63b2be1f2e779b9ecf289fe40693eb943cb260a7d5c95ac6021f35883ade0e4d82e071b86158510fc83cd2c2d61f4a72e6bc6d5c533bacd44eb6a6b97f742d7518f6475f65fb0656fe58d8ad2cc8961c770680c9538593c5a8bc3861fc11e38477076f06911e6de93d9b641b535115700bcdcc863b58b021a7a177b3343e80ab645867061216e191740e4558754e7d13fc3f235743f8d865c0f976a91a3c7912d03e56bb955ddec854c2d661edfc43d5c366040296eac657960a8b40ec6e01b17624d18f32e930b8712cc1a00a2f696229ce10b5b03b3c7c992b601c8ef46390b2fd016687cd1ed4cd70310018dfa97418c7819a0cda7322a7eefa4820001: failed to verify batch: batch hash mismatch, onchain: 3f5b8c23001297ae107370b73956650a20d6cdb2097bddde70de590ef35ef5a9, computed: e7c00bb840cbfaa80b9f505d8df5e5fdbdfe87852908de0628d811b415616702 (Mode: optimism_generic, CertVersion: 0)" commitment_mode=optimism_generic cert_version=0
@samlaf
Copy link
Collaborator Author

samlaf commented Feb 28, 2025

@ethenotethan assigning to you for now. Can you add an explanation for how arbitrum behaves and why this is not an issue? Then reassign to me and I'll reupdate the op part.

@samlaf
Copy link
Collaborator Author

samlaf commented Feb 28, 2025

For op question, just asked on their discord: https://discord.com/channels/1244729134312198194/1316114968613093507/1345085550344015964

@samlaf samlaf assigned samlaf and unassigned ethenotethan Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants