chore: better errors and docs for batch-hash-mismatch error #322
+80
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This permits handling it. Realized while implementing this that there is currently no good way to deal with the error however... but decided to still commit it for better documentation of why this is not possible.
…mentation Explain that this is only possible on op-stack.
ethenotethan
reviewed
Mar 4, 2025
| @@ -2,10 +2,14 @@ | |||
|
|
|||
| List of common bugs and issues that you may encounter while using eigenda-proxy. | |||
|
|
|||
| ## "batch hash mismatch" error | |||
| ## "batch hash mismatch" error (op-stack only) | |||
There was a problem hiding this comment.
Also insecure Orbit integrations (I.e, L3s)
ethenotethan
reviewed
Mar 4, 2025
|
|
||
| This error returned [here](https://github.com/Layr-Labs/eigenda-proxy/blob/97b71bda6e2136a6c0d71be2f7e9642dc840fefc/verify/cert.go#L125) happens when verifying a v1 cert, where the batch hash in the cert does not match the hash that was computed when the cert was bridged onchain by the EigenDA disperser. | ||
|
|
||
| > Note: This error is only relevant for op stacks. Nitro does not suffer from this error because the sequencer inbox is an actual contract which ensures that the cert is valid, as opposed to op's batcher inbox which is just an EOA and hence cannot ensure atomicity of the confirmBatch transaction on the EigenDAServiceManager and the cert being posted to the inbox. |
There was a problem hiding this comment.
Suggested change
| > Note: This error is only relevant for op stacks. Nitro does not suffer from this error because the sequencer inbox is an actual contract which ensures that the cert is valid, as opposed to op's batcher inbox which is just an EOA and hence cannot ensure atomicity of the confirmBatch transaction on the EigenDAServiceManager and the cert being posted to the inbox. | |
| > Note: This error is only relevant for op stacks. Nitro layer2s that settle to an Ethereum network do not suffer from this error because the sequencer inbox is an actual contract which verifies the cert against EigenDA service manager state, as opposed to op's batcher inbox which is just an EOA. Arbitrum Layer 3s that use EigenDA are also susceptible to the mismatch error since certificates can't be verified on the Layer 2 sequencer inbox. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Fixes #320
Fixes DAINT-323
Changes proposed
Realized while trying to implement the fix we have been talking about that there is currently no good way to deal with the error... decided to still commit it for better documentation of why this is not possible. See code comments for explanation.
Also updated the troubleshooting_v1.md docs to explain that this error is only possible on op stack.
Screenshots (Optional)
Note to reviewers