feat: make bindings, wallet and txManager available #224
Conversation
|
I will rebase after #203 get merged, the diff will be much more less by then. |
chainio/clients/builder.go
Outdated
| Wallet wallet.Wallet | ||
| TxManager txmgr.TxManager | ||
| AvsRegistryContractBindings *utils.AvsRegistryContractBindings | ||
| EigenlayerContractBindings *utils.EigenlayerContractBindings |
There was a problem hiding this comment.
@shrimalmadhur any oppositions to returning everything but the kitchen sink in this constructor?
I was thinking we break it up into smaller builders (for eg one for high-level chainio reader/writer/subscribers, and another for low-level interactions), but I don't see any problem with returning everything in here and letting user take whatever they need?
There was a problem hiding this comment.
let me know if you prefer break it, i will adjust my PR, thanks!
There was a problem hiding this comment.
IMO,
we should have 3 exported Methods
BuildELClients - just returns core EL contract Bindings
BuildAVSRegistryClients - just returns AVS resgistry bindings
BuildAllClients - returns all
@samlaf how about this and then user can use based on whatever is needed? I don't want someone to force get AVS registry if not needed.
There was a problem hiding this comment.
#117 this PR does this. I think we can merge that one first then and rebase this one on top?
There was a problem hiding this comment.
Oh really sorry, i didn't notice that there is a PR already! Just make my PR more clean...
There was a problem hiding this comment.
I am totally okay you can go with that one first!
There was a problem hiding this comment.
@renlulu no worries, that was an old one... just merged the other PR. Can you rebase here?
renlulu
force-pushed
the
feat/build-low-level
branch
from
895ac3d to
ba56877
Compare
renlulu
force-pushed
the
feat/build-low-level
branch
from
ba56877 to
164ab6c
Compare
Fixes #220 .
What Changed?
Reviewer Checklist