-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Samlaf avs 559 setup integration test for bls agg #277
Samlaf avs 559 setup integration test for bls agg #277
Conversation
c020d95
to
3e2a0b5
Compare
}) | ||
|
||
t.Run("2 quorums 1 operator", func(t *testing.T) { | ||
// TODO: Implement this test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will come as a separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. there's another issue for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -761,6 +773,126 @@ func TestBlsAgg(t *testing.T) { | |||
}) | |||
} | |||
|
|||
func TestIntegrationBlsAgg(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is unreadable. unclear what's happening: probably better to divide/refactor
- setup
- what is actually being tested
- add comments maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refactored in ba79798. Check now, hopefully its easier to read :D
ba79798
to
8af5916
Compare
…repo was buggy for some reason)
…d on local machine
…ich doesn't need cast to be installed locally
8af5916
to
78ca745
Compare
Fixes # .
What Changed?
Created one integration test for a single quorum.
We'll be able to use this scaffold to augment this to 2 quorums and fix #261 (AVS-494)
Reviewer Checklist