-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor types and utils #42
Comments
Can I pick this up? |
By all means! Do you want to first describe the solution you're thinking of? Like break it down into how you would refactor the files etc? Otherwise, feel free to create a PR, but we might ask you to move things around. |
@samlaf I haven't really given it a thought, but will update the issue with what I think can be done! |
@samlaf I went through the code.
Let me know what you think about this! |
|
Hi, @samlaf! |
Hey @RohanShrothrium |
@0xpanicError I totally forgot about this. Will raise a PR today ser! |
@samlaf I refactored the code with respect to what I mentioned. I will commit this but want to add the following additionally. |
Signed-off-by: Rohan Shrothrium <[email protected]>
Is your feature request related to a problem? Please describe.
We need to refactor types and utils so that it's in some standard way and not create circular dependencies.
Describe the solution you'd like
Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered: