Simplify register operator avswriter fn #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samlaf
force-pushed
the
simplify-register-operator-avswriter-fn
branch
from
9997768 to
0f9e40f
Compare
| var operatorToAvsRegistrationSigSalt [32]byte | ||
| _, err = rand.Read(operatorToAvsRegistrationSigSalt[:]) | ||
| if err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
why Panic? why not return error?
There was a problem hiding this comment.
good catch. prob copied from somewhere and forgot to change. 276562a
|
|
||
| curBlockNum, err := w.ethClient.BlockNumber(context.Background()) | ||
| if err != nil { | ||
| panic(err) |
| } | ||
| curBlock, err := w.ethClient.BlockByNumber(context.Background(), big.NewInt(int64(curBlockNum))) | ||
| if err != nil { | ||
| panic(err) |
samlaf
force-pushed
the
simplify-register-operator-avswriter-fn
branch
from
276562a to
6e4a4f3
Compare
shrimalmadhur
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
What Changed?
Simplify this function which was needlessly complicated. If users need the low level granularity than they can just use the bindings directly is what Im thinking. Most users of the high level writer client probably just want this to happen and not ask too many questions. That's also my case when writing test cases that use this function.
Reviewer Checklist